fix(auth): prevent open redirect and log injection in feedback handlers - #28
Open
cziegeler wants to merge 1 commit into
Open
fix(auth): prevent open redirect and log injection in feedback handlers#28cziegeler wants to merge 1 commit into
cziegeler wants to merge 1 commit into
Conversation
Co-authored-by: Maia <maia@noreply>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the redirect handling in both
DefaultAuthenticationFeedbackHandlerandDefaultJakartaAuthenticationFeedbackHandleragainst open-redirect attacks and log-injection vulnerabilities.Changes:
sendRedirectto relative paths only (must start with/and not contain://); falls back to/for any external or protocol-relative URLsanitizeForLog()helper that escapes CR (\r) and LF (\n) characters to prevent log injectionsanitizeForLog()to all redirect-target values before passing them to logger calls{}placeholder) for consistency and safetyCo-authored-by: Maia maia@noreply